LuXugang commented on PR #12349: URL: https://github.com/apache/lucene/pull/12349#issuecomment-1586551262
>I wonder if this is true, wouldn't skipping also happen if a field doesn't exist? Yes, it won't do skipping. my curiosity was if search sort field does not exist, competitive iterator would be `null` and would not in conjunction with query's iterator in `NumericComparator` but `TermOrdValComparator` will, should they keep the same logic? Hi, @jpountz, another question which not unrelated with this issue: >For instance if collecting 10 top hits, I would expect the collector to collect the first 10 hits produced by the query, and then the competitive iterator would skip every other hit since they cannot possibly be more competitive Yes, in a **single** search sort field(which is not exist) case, It is indeed that every other hit since they cannot possibly be more competitive, but it would still collect all docs because there were as a missing value. in this specific case, could we do some optimization(or maybe there is already some configuration could make it) and see it as a non-search-sort-field case, then such case could get an early terminate collection? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
