dweiss commented on issue #12562: URL: https://github.com/apache/lucene/issues/12562#issuecomment-1722957920
The "build success" here is caused by an explicit change made by Uwe, here: https://github.com/apache/lucene/issues/10513#issuecomment-1224072458 In his own words: The tests.haltonfailure was added back, as it was heavily used by Jenkins. [...] Jenkins wants to differentiate between "build passed, but test failures" vs. "build did not pass due to compile failure, verifications". haltonfailure just reconfigures (like in ant) that the test runner does not exit the whole build with non-success exit code. Jenkins does not rely on exit code, it monitors test result xml files. This makes sense in a CI world. Maybe we should omit printing this flag in the "reproduce with" line though. I'll file a separate issue for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
