cpoerschke commented on code in PR #12436: URL: https://github.com/apache/lucene/pull/12436#discussion_r1341157051
########## lucene/core/src/java/org/apache/lucene/index/IndexingChain.java: ########## @@ -831,6 +837,20 @@ private static void verifyUnIndexedFieldType(String name, IndexableFieldType ft) } } + private static void validateMaxVectorDimension( + String fieldName, int vectorDim, int maxVectorDim) { + if (vectorDim > maxVectorDim) { + throw new IllegalArgumentException( + "Field [" + + fieldName + + "]" + + "vector's dimensions must be <= [" Review Comment: minor: #12605 proposes to have a space before the `vector's dimensions` words here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org