mikemccand commented on issue #10520: URL: https://github.com/apache/lucene/issues/10520#issuecomment-1744944312
> I'm planning to refactor the BytesStore into an interface that can be chosen from the FST builder. And one can decide whether on-heap or off-heap or on-heap without blocks is best suited. Awesome, thanks @dungba88! But, at write time, can we avoid `BytesStore` entirely, maybe? Just write to a `DataOutput`? But we would need to first refactor `FST#addNode` to not use this `reverse` method on `BytesStore`, and do its own `byte[]` buffering/reversal before writing? If possible, can we do this as a first step, which we test/merge before making the change to move to `DataOutput`? Let's have further discussions on #12543? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
