s1monw commented on PR #12711: URL: https://github.com/apache/lucene/pull/12711#issuecomment-1776831638
I spoke to @jpountz about this topic and we discussed a different approach. We could get away with not having the check at all and make blocks a first class citizen by recording the parent document in a docvalues field. Really, if we'd be implementing the feature today would we use a bitset or maybe a sparse DV field recording the number of children for each block in the index? I guess the latter... We could ask the user for a field to record this in IWC and make blocks a first class citizen. That way we can sort only on the parent documents which would make things for you (@mikemccand and @msokolov) and maybe other users simpler and more safe. You'd still have the power to do what you do today but we can fix documentation that your blocks might be messed up unless you set a field on IWC. Full BWC and less trouble for the users? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
