benwtrent commented on code in PR #12660: URL: https://github.com/apache/lucene/pull/12660#discussion_r1370034532
########## lucene/core/src/java/org/apache/lucene/util/hnsw/NeighborArray.java: ########## @@ -35,6 +38,9 @@ public class NeighborArray { float[] score; int[] node; private int sortedNodeSize; + public final ReadWriteLock rwlock = new ReentrantReadWriteLock(true); Review Comment: We can make it a refactor later, but I am convinced we will want a separate `*NeighborArray` class for concurrent vs. serial graph building. There is no technical reason to slow down serial graph building and I think we can make concurrent even nicer by freeing itself from having to even think about serial graph building. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org