mikemccand commented on PR #354: URL: https://github.com/apache/lucene/pull/354#issuecomment-1790501879
Whoa, sneaky -- indeed the `Stream` returned from `Files.list` must be closed (it holds a `DirectoryStream` open under-the-hood)! I grep'd Lucene's sources for other places we use `Files.list` and they all seem to use try-with-resources, so no leak except for the `ExtractReuters.java`. Thanks @lujiefsi and sorry for the crazy slow response. I'll merge for Lucene 10.0 and backport to 9.x. The leak should not really be user impacting since one extracts the Reuters corpus once usually for benchmarking. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
