kevindrosendahl commented on code in PR #12780:
URL: https://github.com/apache/lucene/pull/12780#discussion_r1386980331
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99ScalarQuantizedVectorsWriter.java:
##########
@@ -143,6 +143,13 @@ private void
writeQuantizedVectors(QuantizationFieldVectorWriter fieldData) thro
byte[] vector = new byte[fieldData.dim];
final ByteBuffer offsetBuffer =
ByteBuffer.allocate(Float.BYTES).order(ByteOrder.LITTLE_ENDIAN);
for (float[] v : fieldData.floatVectors) {
+ if (fieldData.normalize) {
+ float[] copy = new float[v.length];
Review Comment:
Good catch, changed in
https://github.com/apache/lucene/pull/12780/commits/1d9f68be208ad2b111640d370bee8f410203099f
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
