shubhamvishu commented on PR #12868: URL: https://github.com/apache/lucene/pull/12868#issuecomment-1838021938
> Maybe we should take advantage of this change to simplify this postings format, by no longer making the hash function configurable, removing the abstraction for hash functions, and cutting over to StringHelper to compute hashes instead of introducing a new implementation? @jpountz Makes sense, +1 .to remove the abstraction Though I have a couple of points/questions here : 1. Do you mean to change `StringHelper` class to add support for 128 bit hash because currently it creates 32-bit hash with Murmur 3? or maybe moving `BytesRefHash` to also use 128-bit hash? 2. `StringHelper` doesn't seem like the most intuitive place for a hash function implementation like this. Do you think we should instead have or copy to something like `HashHelper` or `HashUtil`? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
