uschindler commented on code in PR #12878:
URL: https://github.com/apache/lucene/pull/12878#discussion_r1416143382
##########
lucene/benchmark-jmh/src/java/org/apache/lucene/benchmark/jmh/ExpressionsBenchmark.java:
##########
@@ -83,12 +82,8 @@ private static double ident(double v) {
private static final Expression NATIVE_IDENTITY_EXPRESSION =
new Expression(NATIVE_IDENTITY_NAME, new String[] {"x"}) {
@Override
- public double evaluate(DoubleValues[] functionValues) {
- try {
- return functionValues[0].doubleValue();
- } catch (IOException e) {
- throw new UncheckedIOException(e);
Review Comment:
this was just the workaround I applied that made me aware of this bug in the
expressions module.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
