gsmiller commented on code in PR #12864: URL: https://github.com/apache/lucene/pull/12864#discussion_r1416215309
########## lucene/CHANGES.txt: ########## @@ -7,7 +7,8 @@ http://s.apache.org/luceneversions API Changes --------------------- -(No changes) +* GITHUB#12243: Mark TermInSetQuery ctors with varargs terms as @Deprecated. SortedSetDocValuesField#newSlowSetQuery, +SortedDocValuesField#newSlowSetQuery, KeywordField#newSetQuery now take a collection of terms as a param. (Jakub Slowinski) Review Comment: minor: let's left-pad with some whitespace like we do with other changes entries ########## lucene/core/src/java/org/apache/lucene/document/KeywordField.java: ########## @@ -170,7 +171,9 @@ public static Query newExactQuery(String field, String value) { * @param values the set of values to match * @throws NullPointerException if {@code field} is null. * @return a query matching documents with this exact value + * @deprecated Use the method with a collection of values instead. Review Comment: minor: let's use the `{@link ...}` javadoc to reference the methods users should use (in all places where we're using this annotation)? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
