dweiss commented on issue #12961: URL: https://github.com/apache/lucene/issues/12961#issuecomment-1866918536
I won't stand in the way if others want those .gitattributes - I just expressed my opinion. Do yourself a favor and switch it off globally, really. This should be the default on Windows. I've spent countless hours trying to figure out why git checked out something that really wasn't there (at least not for anybody else on the planet) - this happens over and over again if you have automatic conversions in place. > Then contributors on Windows will be pushing files with CR LF line breaks to the server? At least they know that what they've checked in is the same as what they have locally, byte-to-byte. As a Windows user myself, I don't see this as a bigger harm than git replacing stuff for me automatically. And nobody can convince me otherwise, sorry. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org