uschindler commented on PR #12841: URL: https://github.com/apache/lucene/pull/12841#issuecomment-1867866005
> Change looks good to me, thanks for running the micro benchmarks again. > > I was thinking we'd backport this to 9.x, since this doesn't look like it would break anything. This would also help nightly benchmarks stay more in line with the stable branch. No strong feelings though, if @uschindler likes it better as a 10.0 only change, that's fine with me. I think you're right. My problem was that the MMapDirectory changes regarding the ByteBufferIndexInput impl and NIOFSDir may be slower on 11. As we backed out those changes, I see no reason not to backport it. If somebody uses memory segments he she is already on java 19+. I'd still like to check perf of the other changes on java 11 (ByteBuffers)! Anyways, we should stop working on 9.x. Uwe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
