jpountz commented on code in PR #12996:
URL: https://github.com/apache/lucene/pull/12996#discussion_r1444536935
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/LZ4WithPresetDictCompressionMode.java:
##########
@@ -128,10 +128,12 @@ public void decompress(DataInput in, int originalLength,
int offset, int length,
}
// Read blocks that intersect with the interval we need
+ if (offsetInBlock < offset + length) {
Review Comment:
I'd rather keep using `grow` over `growExact`. This helps make sure we don't
keep allocating a new array in cases lengths grow in small increments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
