dungba88 commented on code in PR #12985:
URL: https://github.com/apache/lucene/pull/12985#discussion_r1448927527


##########
lucene/core/src/java/org/apache/lucene/codecs/lucene90/blocktree/Lucene90BlockTreeTermsWriter.java:
##########
@@ -795,7 +783,12 @@ void writeBlocks(int prefixLength, int count) throws 
IOException {
 
       assert firstBlock.isFloor || newBlocks.size() == 1;
 
-      firstBlock.compileIndex(newBlocks, scratchBytes, scratchIntsRef);
+      boolean isRootBlock = prefixLength == 0 && count == pending.size();

Review Comment:
   I can make this a parameter to be clearer instead of inferring from 
prefixLength and count



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to