stefanvodita commented on code in PR #13060:
URL: https://github.com/apache/lucene/pull/13060#discussion_r1490019625
##########
lucene/analysis/phonetic/src/java/org/apache/lucene/analysis/phonetic/DaitchMokotoffSoundexFilter.java:
##########
@@ -32,10 +32,10 @@
*/
public final class DaitchMokotoffSoundexFilter extends TokenFilter {
/** true if encoded tokens should be added as synonyms */
- protected boolean inject = true;
+ final boolean inject;
Review Comment:
Since this class is marked with `@lucene.experimental`, we can make the
change.
##########
lucene/analysis/phonetic/src/java/org/apache/lucene/analysis/phonetic/PhoneticFilter.java:
##########
@@ -32,13 +32,13 @@
*/
public final class PhoneticFilter extends TokenFilter {
/** true if encoded tokens should be added as synonyms */
- protected boolean inject = true;
+ final boolean inject;
Review Comment:
It's a strange case. We're not really breaking backwards compatibility,
since no one could have accessed this field anyway with the class being final.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
