jpountz commented on PR #13115: URL: https://github.com/apache/lucene/pull/13115#issuecomment-1954568783
FYI I played with this change and [IndexGeoNames](https://github.com/mikemccand/luceneutil/blob/master/src/main/perf/IndexGeoNames.java) which has been good at detecting contention in the past. I first modified the benchmark to call `iwc.setCheckPendingFlushUpdate(false);` and saw little difference. Then I disabled the 3 text fields, which is where most indexing time goes, and could see a noticeable difference when indexing with 30 threads. Before this change it took ~6.5s to fill up IndexWriter's buffer. After this change it took only ~5.5s to fill up IndexWriter's buffer, a significant improvement! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
