mikemccand commented on PR #13190:
URL: https://github.com/apache/lucene/pull/13190#issuecomment-2009418841

   > Selfishly, I wish for the second option as its the simplest.
   
   +1 to keep with the second approach.  It is best effort, and, the "instant 
vs burst-bucket" bug above is yet more weirdness about it :)
   
   Another thought on the "instant vs burst-bucket" bug: I suppose in some 
case, e.g. bulk merging of stored fields (no deletions, so we are just copying 
byte blocks), there is very little CPU and tons of IO and in cases like that, 
the instant vs burst-bucket approaches would be essentially the same (both wind 
up throttling based on the instant rate since the burst bucket is quickly 
exhausted).  I'll open a spinoff ...


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to