mikemccand commented on code in PR #11888:
URL: https://github.com/apache/lucene/pull/11888#discussion_r1541892891
##########
lucene/core/src/test/org/apache/lucene/codecs/lucene99/TestLucene99PostingsFormat.java:
##########
@@ -143,4 +141,13 @@ private void doTestImpactSerialization(List<Impact>
impacts) throws IOException
}
}
}
+
+ @Override
+ protected void subCheckBinarySearch(TermsEnum termsEnum) throws Exception {
+ // 10004a matched block's entries: [100001, 100003, ..., 100049].
+ // if target greater than the last entry of the matched block,
+ // termsEnum.term should be the last entry.
+ assertFalse(termsEnum.seekExact(new BytesRef("10004a")));
+ assertEquals(termsEnum.term(), new BytesRef("100049"));
Review Comment:
Well, I think we need to find a way to test this bug w/o abusing the API.
Our tests should not violate our APIs ...
Is there a `seekCeil` based test case we can make?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
