benwtrent commented on code in PR #13627:
URL: https://github.com/apache/lucene/pull/13627#discussion_r1705881356
##########
lucene/core/src/java/org/apache/lucene/index/DocumentsWriterPerThreadPool.java:
##########
@@ -138,6 +138,15 @@ private synchronized boolean
contains(DocumentsWriterPerThread state) {
void marksAsFreeAndUnlock(DocumentsWriterPerThread state) {
final long ramBytesUsed = state.ramBytesUsed();
+ assert state.isFlushPending() == false
+ && state.isAborted() == false
+ && state.isQueueAdvanced() == false
+ : "DWPT has pending flush: "
+ + state.isFlushPending()
+ + " aborted="
+ + state.isAborted()
+ + " queueAdvanced="
+ + state.isQueueAdvanced();
Review Comment:
The only place where we call this method is also where we check ALL these
conditions. It just seemed prudent to add these assertions as the call flow
obviously expects this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
