original-brownbear commented on PR #13885: URL: https://github.com/apache/lucene/pull/13885#issuecomment-2407269525
Hmm I tried and failed miserably to find a solution to initialize in `reset()` that I fully understand :) It's quite hard to reason about all the possible paths here for me, but I see your point. As far as specialization goes, that one I could find a version that didn't show runtime regressions (because callsites + polymorphism). Maybe do a little cleanup along the lines of https://github.com/apache/lucene/pull/13892 first then get back to this? :) It's hard to fix this without complicating the code, this is the simplest version I could find but I see your points. I bet if we clean up all the duplication that we can cleanup without runtime overhead, we'll find an easier fix here :) wdyt? (this one also isn't so urgent, it's very few cycles runtime, mostly a p100 thing for JVMs under GC pressure probably) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
