gf2121 commented on code in PR #14532:
URL: https://github.com/apache/lucene/pull/14532#discussion_r2053874070
##########
lucene/core/src/java/org/apache/lucene/search/comparators/UpdateableDocIdSetIterator.java:
##########
@@ -14,20 +14,24 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-
package org.apache.lucene.search.comparators;
import java.io.IOException;
+import java.util.Objects;
import org.apache.lucene.search.AbstractDocIdSetIterator;
+import org.apache.lucene.search.DocIdSetIterator;
+import org.apache.lucene.util.FixedBitSet;
+
+final class UpdateableDocIdSetIterator extends AbstractDocIdSetIterator {
-/** Docs iterator that starts iterating from a configurable minimum document */
-public class MinDocIterator extends AbstractDocIdSetIterator {
- final int segmentMinDoc;
- final int maxDoc;
+ private DocIdSetIterator in = DocIdSetIterator.empty();
Review Comment:
Nit: It looks like `UpdateableDocIdSetIterator` always need to be updated
after construction, would it be better to have a constructor taking a
DocIdSetIterator?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
