rmuir commented on PR #14901:
URL: https://github.com/apache/lucene/pull/14901#issuecomment-3045136801

   The bug Uwe found is truly crazy. Need to step back here and fix SOMETHING 
to fail on it...
   
   No java linter finds the issue at compile time, which is really surprising 
to me. With clang the problem is caught immediately by 
`-Wformat-insufficient-args`, it is the kind of silly mistake I'd expect to be 
caught at compile time.
   
   ![Screen_Shot_2025-07-07_at_09 15 
24](https://github.com/user-attachments/assets/e718eb3a-b9d7-4bc0-b1b1-78e11e4379d0)
   
   At runtime, the test passes, UNLESS you run it with `-Dtests.verbose`, then 
it fails.
   
   ![Screen_Shot_2025-07-07_at_09 20 
49](https://github.com/user-attachments/assets/0abe9ee1-1778-4872-93c1-81c2bc5fdf13)
   
   In the short-term, I think this is the easiest to address. I know we don't 
want tests to print but maybe we can hack the test so it fails without 
`-Dtests.verbose`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org

Reply via email to