uschindler commented on PR #14901: URL: https://github.com/apache/lucene/pull/14901#issuecomment-3045736360
Thats all fine, then remove the constant. It is no longer risky because the bail out is at one single place: In production Maybe add a constant called "PANAMA_TEST_MODE" that is enabled once you set bitsize. Let's remove the second sysprop, just keep the "bitsize". Once any bitsize is enabled, lets stay in test mode and therefor the tests for integers should run. That is a one-line change, so it does not add confusion, just rename the constant. I am just waiting for you to finish and then add my changes, I did not want to interfere with you. Sorry: I wrote the original code with the systemprops. It's a bit complicated, so I only try to help. And because of the problem with the formatter we noticed the problem at all: Github runner never executes Panama Tests anymore, because it has no AVX2. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
