uschindler commented on code in PR #14942:
URL: https://github.com/apache/lucene/pull/14942#discussion_r2203227558
##########
build-tools/build-infra/src/main/groovy/lucene.java.core.mrjar.gradle:
##########
@@ -29,9 +31,13 @@ configure(project(":lucene:core")) {
configurations["main${jdkVersion}Implementation"].extendsFrom(configurations.maybeCreate("implementation"))
dependencies.add("main${jdkVersion}Implementation",
sourceSets.main.output)
- tasks.named("compileMain${jdkVersion}Java").configure {
- def apijar = apijars.file("jdk${jdkVersion}-api.jar")
+ def apijar = apijars.file("jdk${jdkVersion}-api.jar")
+
tasks.withType(CheckForbiddenApis).named("forbiddenApisMain${jdkVersion}").configure
{
+ it.classpath = it.classpath + files(apijar)
Review Comment:
I would exchange order to habe the incubator API first on class path. But
that's just nitpicking.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
