jpountz commented on code in PR #14932:
URL: https://github.com/apache/lucene/pull/14932#discussion_r2247938079
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsReader.java:
##########
@@ -76,6 +79,7 @@ public final class Lucene99HnswVectorsReader extends
KnnVectorsReader
private final FieldInfos fieldInfos;
private final IntObjectHashMap<FieldEntry> fields;
private final IndexInput vectorIndex;
+ private final Populator dataReader;
Review Comment:
FWIW the extra abstraction doesn't make things easier to read / understand
to me. I'd rather use a plain `if` statement in the decoding logic:
```java
if (version >= VERSION_GROUPVARINT) {
// read using group-varint
} else {
// read using DataInput#readVInt()
}
// prefix sum
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
