kaivalnp commented on code in PR #14863:
URL: https://github.com/apache/lucene/pull/14863#discussion_r2253101132
##########
lucene/core/src/java24/org/apache/lucene/internal/vectorization/PanamaVectorUtilSupport.java:
##########
@@ -563,8 +633,42 @@ private int dotProductBody256Int4Packed(byte[] unpacked,
byte[] packed, int limi
return sum;
}
+ private static int dotProductBody256Int4PackedPacked(
Review Comment:
Makes sense, I mainly kept separate functions for parity with existing code.
Would be great to parameterize and shorten, since we aren't doing anything
specific (like we do for, say, full-byte dot products)
I'll add a commit for this soon!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
