cwperks commented on PR #15120: URL: https://github.com/apache/lucene/pull/15120#issuecomment-3220723408
> so this moves the accounting from deep in `registerMerge` to the top? Did the test fail before this change? @msokolov merges registered in `public void registerMerge(MergePolicy.OneMerge merge)` did not get the estimated bytes added like those registered in `private synchronized boolean registerMerge(MergePolicy.OneMerge merge)` do which leads to this [information missing in log statements](https://github.com/apache/lucene/issues/14993) like the one's pointed out in the issue description. I added a new unit test for the new method `testAddEstimatedBytesToMerge`, but I think it may also be good to ensure merges get this information regardless of how they're registered in an integration test. Do you know the proper place to add a test like that? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
