jpountz commented on code in PR #15116:
URL: https://github.com/apache/lucene/pull/15116#discussion_r2299064975
##########
lucene/core/src/java/org/apache/lucene/util/GroupVIntUtil.java:
##########
@@ -56,7 +58,54 @@ public static void readGroupVInts(DataInput in, int[] dst,
int limit) throws IOE
* @param dst the array to read ints into.
* @param offset the offset in the array to start storing ints.
*/
- public static void readGroupVInt(DataInput in, int[] dst, int offset) throws
IOException {
+ private static void readGroupVInt(DataInput in, int[] dst, int offset)
throws IOException {
+ final int flag = in.readByte() & 0xFF;
+
+ final int n1Minus1 = flag >> 6;
+ final int n2Minus1 = (flag >> 4) & 0x03;
+ final int n3Minus1 = (flag >> 2) & 0x03;
+ final int n4Minus1 = flag & 0x03;
+
+ // if our DataInput implements RandomAccessInput for absolute access and
IndexInput for seeking,
+ // we use a branch-less implementation:
+ if (in instanceof RandomAccessInput rin && in instanceof IndexInput iin) {
+ long pos = iin.getFilePointer();
+ if (iin.length() - pos >= MAX_LENGTH_PER_GROUP - 1) {
Review Comment:
FWIW the following reads a bit easier to me. It's very clear since it reads
4 integers a few lines below. Versus understanding what this constant is and
why we need to subtract one.
```suggestion
if (iin.length() - pos >= 4 * Integer.BYTES) {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
