jainankitk commented on code in PR #15083:
URL: https://github.com/apache/lucene/pull/15083#discussion_r2302089486
##########
lucene/core/src/java/org/apache/lucene/index/DocValuesSkipper.java:
##########
@@ -122,4 +123,67 @@ public final void advance(long minValue, long maxValue)
throws IOException {
advance(maxDocID + 1);
}
}
+
+ /**
+ * Returns the minimum value for a field across all segments, or {@link
Long#MIN_VALUE} if not
+ * available
+ *
+ * @param searcher a searcher over the index
+ * @param field the field to retrieve values for
+ */
+ public static long globalMinValue(IndexSearcher searcher, String field)
throws IOException {
+ long minValue = Long.MAX_VALUE;
+ for (LeafReaderContext ctx : searcher.getLeafContexts()) {
+ if (ctx.reader().getFieldInfos().fieldInfo(field) == null) {
+ continue; // no field values in this segment, so we can ignore it
+ }
+ DocValuesSkipper skipper = ctx.reader().getDocValuesSkipper(field);
+ if (skipper == null) {
+ minValue = Long.MIN_VALUE;
Review Comment:
Thanks @romseygeek for this change. I missed this PR earlier, just noticed
that we can exit early if skipper is null for one of the leaves. Opened small
followup with this change - https://github.com/apache/lucene/pull/15127
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org
For additional commands, e-mail: issues-h...@lucene.apache.org
