RamakrishnaChilaka commented on PR #15135: URL: https://github.com/apache/lucene/pull/15135#issuecomment-3233139036
Thanks for review @jpountz. For example, if the docValues are sorted in ascending order, and lowerValue & upperValue is greater than the max of the segment. We would call advance [SortedNumericDocValuesRangeQuery, L#259]( https://github.com/apache/lucene/blob/main/lucene/core/src/java/org/apache/lucene/document/SortedNumericDocValuesRangeQuery.java#L259), exhausting the skipper. Subsequent calls to nextDoc is almost no-op and calling advance on the upperValue is almost a no-op too. TLDR, For ascending/descending-sorted segments, in this PR, we skip skipper.advance call which would exhaust the skipper, if lowerValue and upperValue are out of range. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
