mikemccand commented on PR #15116: URL: https://github.com/apache/lucene/pull/15116#issuecomment-3237013405
> > > And you still dont explain what the "X" means. If it is a percentage like title of column says it's plain wrong, as the improvement is 3%. If it is a factor (1.03 X; X like times???) it has too few digits. > > > > > > 1X (that is my new way of agreeing "100%") > > Then title of column is wrong. If it is 100% change it would be great! I just pushed a fix so at least we get more than 1 digit of precision there! `Prefix3` improvement on [08/25 run](https://benchmarks.mikemccandless.com/2025.08.25.18.04.16.html) will be more like `1.0362 X` going forwards... but, yeah, the column header is wrong too!! Long ago I used `X` (multiple-of) because we were tinkering with improvements that were many-fold hah. Now that we are excited about 3-5% improvements I will fix the units! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
