RamakrishnaChilaka commented on PR #15140: URL: https://github.com/apache/lucene/pull/15140#issuecomment-3242942557
Thanks @jpountz for reviewing this PR. I agree that it makes sense to keep `LongHeap` binary for now, given the scope of our current benchmarks. As you suggested, I’ll refactor the shared logic into static helpers `upHeap`/`downHeap` that take `arity` as a constant, introduce a `TernaryLongHeap` class with `arity=3` hardcoded, and switch only top-hits collectors to use it in this PR. We can then revisit vector search in a follow-up once we have benchmarks for that workload to validate whether it benefits from the same change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
