zhaih commented on code in PR #15184:
URL: https://github.com/apache/lucene/pull/15184#discussion_r2349546069
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##########
@@ -144,8 +148,8 @@ protected HnswGraphBuilder(
throw new IllegalArgumentException("beamWidth must be positive");
}
this.M = hnsw.maxConn();
- this.scorerSupplier =
- Objects.requireNonNull(scorerSupplier, "scorer supplier must not be
null");
+ this.scorer =
+ Objects.requireNonNull(scorerSupplier, "scorer supplier must not be
null").scorer();
Review Comment:
It's actually still asserting on `scorerSupplier` (which is passed in to
ctor)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]