romseygeek commented on PR #15167: URL: https://github.com/apache/lucene/pull/15167#issuecomment-3301851113
I agree with @alexmm-amzn, I think this needs to use the return value of `GroupSelector#advanceTo(int)` to distinguish between actual `null` values and missing values, and that `ValueSourceGroupSelector` should be updated to behave more like the other implementations. This also reminds me that at some point I should get round to deprecating `ValueSource`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
