RamakrishnaChilaka commented on PR #15165: URL: https://github.com/apache/lucene/pull/15165#issuecomment-3265115187
Thanks for the review @jpountz. > I would skip the changelog too for such a change, it has no user-facing impact? Yes, there's no user-facing change. > I have been wondering about this bit of code recently as well, and I wonder if we should swap the (Int|Long)Heap with an int[32] that stores the number of values for each required number of bits per value? I agree. Currently we use `IntHeap`/`LongHeap` to extract the top 8 (7 exceptions + 1 max value (other than the exceptions) from the supplied ints) elements and compare their required bits. However, the max_exception value is static. Using an int[32] histogram of values by bit width would simplify the logic. In addition, it could give us flexibility to make the number of exceptions dynamic rather than fixed, which might lead to better compression in some cases. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: issues-unsubscr...@lucene.apache.org For additional commands, e-mail: issues-h...@lucene.apache.org
