dweiss commented on code in PR #15252:
URL: https://github.com/apache/lucene/pull/15252#discussion_r2388080358
##########
build-tools/build-infra/src/main/java/org/apache/lucene/gradle/plugins/ide/EclipseSupportPlugin.java:
##########
@@ -172,23 +153,57 @@ private void configureEclipseIdeSettings(Project project,
String eclipseJavaVers
task.dependsOn(luceneEclipseJdt);
});
+ // Add gradle plugin portal to the source repository list and
+ // apply any ecj source repository hackery the same way as everywhere.
+ project.getRepositories().gradlePluginPortal();
+ project.apply(conf ->
conf.from(project.file("build-tools/build-infra/ecj-source.gradle")));
+
tasks
.withType(GenerateEclipseClasspath.class)
.named("eclipseClasspath")
.configure(
task -> {
+ var classpath = task.getClasspath();
+ classpath.setDefaultOutputDir(project.file("build/eclipse"));
+ classpath.setDownloadJavadoc(false);
+ classpath.setDownloadSources(true);
+
+ // Collect dependencies from selected configurations
+ // and copy them over to a local configuration.
+ List<Dependency> subdependencies = new ArrayList<>();
Review Comment:
I think you can theoretically imagine a situation with two configurations
having a transitive dependency in different versions - then it would resolve
this differently... I think. I wouldn't worry about it though, it's a hack
already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
