shubhamvishu commented on code in PR #14963:
URL: https://github.com/apache/lucene/pull/14963#discussion_r2446071334
##########
lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99HnswVectorsFormat.java:
##########
@@ -152,7 +177,20 @@ public Lucene99HnswVectorsFormat() {
* @param beamWidth the size of the queue maintained during graph
construction.
*/
public Lucene99HnswVectorsFormat(int maxConn, int beamWidth) {
- this(maxConn, beamWidth, DEFAULT_NUM_MERGE_WORKER, null);
+ this(maxConn, beamWidth, DEFAULT_NUM_MERGE_WORKER, null,
HNSW_GRAPH_THRESHOLD, VERSION_CURRENT);
+ }
+
+ /**
+ * Constructs a format using the given graph construction parameters.
+ *
+ * @param maxConn the maximum number of connections to a node in the HNSW
graph
+ * @param beamWidth the size of the queue maintained during graph
construction.
+ * @param tinySegmentsThreshold the value of k for the expectedVisitedNodes
heuristic, used to
+ * determine the minimum required graph nodes
Review Comment:
The wording makes sense to me, I'll rephrase
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
