mikemccand commented on PR #15341: URL: https://github.com/apache/lucene/pull/15341#issuecomment-3426589180
> I see another action item from this benchmark: I wasn't aligning the output inside [this merge function](https://github.com/apache/lucene/blob/eb27b14eaa09c53496a50c5944160b4989910882/lucene/core/src/java/org/apache/lucene/codecs/lucene99/Lucene99FlatVectorsWriter.java#L252-L253), which is used by HNSW-based vector formats for merging (see that index(s) improved in my benchmark, but not force_merge(s) -- which should speed up after this additional change?) Oh good catch! I wonder what other places might write the flat vectors? Is the alignment also (or maybe less) important for the quantized cases? (Your results above are for `float32` vectors?) Maybe at least `luceneutil` could somehow warn if vectors are unaligned during its perf testing? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
