rmuir commented on PR #15386:
URL: https://github.com/apache/lucene/pull/15386#issuecomment-3470462476

   slightly related, I can try to dig more into it later, but I've been 
unsuccessful at figuring out the correct incantation to `google-java-format` 
for our sources.
   
   purpose would be to make it possible to configure format-on-save workflow 
for vim, vscode, etc.
   
   The tool is not particularly fast, but it is fast enough when only 
formatting a single file... the one you just edited. 
   
   ```
   lucene[main]$ google-java-format -i 
lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
   lucene[main]$ git diff
   diff --git a/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java 
b/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
   index aa2c92ffecc..026f339956f 100644
   --- a/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
   +++ b/lucene/core/src/java/org/apache/lucene/index/IndexWriter.java
   @@ -637,7 +637,8 @@ public class IndexWriter
                          MergeTrigger.GET_READER,
                          sci -> {
                            assert stopCollectingMergedReaders.get() == false
   -                            : "illegal state  merge reader must be not 
pulled since we already stopped waiting for merges";
   +                            : "illegal state  merge reader must be not 
pulled since we already"
   +                                  + " stopped waiting for merges";
                            SegmentReader apply = readerFactory.apply(sci);
                            mergedReaders.put(sci.info.name, apply);
                            // we need to incRef the files of the opened SR 
otherwise it's possible that
   ...
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to