kaivalnp commented on PR #15285: URL: https://github.com/apache/lucene/pull/15285#issuecomment-3518612504
Thanks @mikemccand, IIUC Uwe's main concern was to _not_ expose incubating / experimental APIs (i.e. the Vector API) publicly (which was true in this PR) -- I'm not sure what else to look out for.. One other potential issue I see is the renaming of public APIs -- like `VectorUtil::dotProduct` -> `VectorUtil::dotProductBytes` / `VectorUtil::dotProductFloats` -- earlier, we didn't expose signatures for off-heap computations, so the signature was `VectorUtil::dotProduct(byte[], byte[])` and `VectorUtil::dotProduct(float[], float[])`), but now that we do -- they'll both be `VectorUtil::dotProduct(MemorySegment, MemorySegment)` -- and need to be separated. I'll pull out of draft! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
