mikemccand commented on code in PR #15472:
URL: https://github.com/apache/lucene/pull/15472#discussion_r2619368757
##########
lucene/sandbox/build.gradle:
##########
@@ -16,12 +16,25 @@
*/
+plugins {
+ id 'java-library'
+}
description = 'Various third party contributions and new ideas'
+java {
+ modularity.inferModulePath = true
+}
+
dependencies {
moduleApi project(':lucene:core')
moduleApi project(':lucene:queries')
moduleApi project(':lucene:facet')
moduleTestImplementation project(':lucene:test-framework')
+
+ moduleImplementation('io.github.jbellis:jvector:4.0.0-rc.5') {
Review Comment:
> before merging this has to be cleaned up. Lucene does not want
delectations of external dependencies with version numbers here. Needs to move
to version.toml file.
+1 -- this PR is still very much draft I think. Thanks @uschindler.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
