romseygeek commented on issue #15480: URL: https://github.com/apache/lucene/issues/15480#issuecomment-3674775395
The one remaining non-final method is `comparatorSource` which is only used by custom sorts. Given the tight coupling between `SortField.Type` and the comparator factory methods, I wonder if it makes sense to set `comparatorSource` for all types and add some basic factory methods to the various different FieldComparator implementations. Then `SortField.getComparator()` just becomes a simple call to `comparatorSource.getComparator()`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
