dsmiley commented on code in PR #15434:
URL: https://github.com/apache/lucene/pull/15434#discussion_r2648524347
##########
lucene/highlighter/src/java/org/apache/lucene/search/vectorhighlight/FieldQuery.java:
##########
@@ -429,7 +429,7 @@ private void markTerminal(float boost) {
private void markTerminal(int slop, float boost) {
this.terminal = true;
this.slop = slop;
- this.boost = boost;
+ this.boost = Math.max(this.boost, boost);
Review Comment:
It's a fine suggestion but it's also a trivial matter. I'd even argue the
complexity of the condition you propose makes the situation worse.... a future
reader may scratching their heads for a little longer than merits the code
being avoided.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
