rmuir commented on PR #15584: URL: https://github.com/apache/lucene/pull/15584#issuecomment-3764429325
> I swear I posted a comment over on the linked issue, but today I don't see it. Basically just wondering what can go wrong at search time. I added some randomness to the test infra here to see if we can catch some flies. I guess someone might try using BM25 simlarity with this field, or some scoring that assumes that totalTermFrequency > termFrequency(doc)? Searching and pruning would be my concerns. Look at BaseSimilarityTestCase for the former. Enabling the option randomly won't find anything unless you actually trigger the excessive values too, I think test logic for the similarities must be explicit. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
