shubhamsrkdev commented on code in PR #15585:
URL: https://github.com/apache/lucene/pull/15585#discussion_r2705209143
##########
lucene/core/src/java/org/apache/lucene/store/MemorySegmentIndexInput.java:
##########
@@ -40,6 +40,22 @@
* chunkSizePower</code>).
*/
abstract class MemorySegmentIndexInput extends IndexInput implements
MemorySegmentAccessInput {
+
+ /** Shared counter for prefetch hit tracking. */
+ static final class SharedPrefetchCounter {
+ private int count;
Review Comment:
Yes, I did that - looks like they are almost the same `AtomicInteger` being
somewhat better?
- `volatile`
```
TaskQPS baseline StdDevQPS
my_modified_version StdDev Pct diff p-value
BrowseDayOfYearTaxoFacets 3.28 (9.4%) 3.20
(4.8%) -2.6% ( -15% - 12%) 0.280
BrowseDateTaxoFacets 3.24 (7.9%) 3.18
(4.9%) -2.0% ( -13% - 11%) 0.331
TermDTSort 261.53 (3.2%) 259.46
(3.5%) -0.8% ( -7% - 6%) 0.457
range 3676.85 (4.3%) 3660.49
(5.1%) -0.4% ( -9% - 9%) 0.764
BrowseRandomLabelTaxoFacets 2.40 (4.3%) 2.39
(2.0%) -0.4% ( -6% - 6%) 0.691
MedIntervalsOrdered 147.92 (6.6%) 147.43
(6.4%) -0.3% ( -12% - 13%) 0.872
HighIntervalsOrdered 17.40 (8.7%) 17.35
(9.0%) -0.3% ( -16% - 19%) 0.914
OrHighNotHigh 371.74 (5.7%) 370.95
(6.3%) -0.2% ( -11% - 12%) 0.911
OrNotHighHigh 266.13 (6.5%) 265.65
(6.8%) -0.2% ( -12% - 13%) 0.931
IntNRQ 466.76 (1.9%) 466.10
(1.9%) -0.1% ( -3% - 3%) 0.812
HighSpanNear 34.12 (3.3%) 34.11
(4.6%) -0.0% ( -7% - 8%) 0.991
LowIntervalsOrdered 116.50 (2.5%) 116.49
(2.5%) -0.0% ( -4% - 5%) 0.991
OrHighMedDayTaxoFacets 7.60 (1.9%) 7.60
(1.9%) 0.1% ( -3% - 3%) 0.860
HighTermTitleBDVSort 31.69 (2.3%) 31.80
(2.2%) 0.3% ( -4% - 4%) 0.625
BrowseMonthTaxoFacets 2.75 (1.7%) 2.76
(0.3%) 0.4% ( -1% - 2%) 0.356
AndHighHighDayTaxoFacets 29.66 (1.4%) 29.77
(1.2%) 0.4% ( -2% - 2%) 0.387
HighSloppyPhrase 35.65 (2.0%) 35.78
(2.6%) 0.4% ( -4% - 5%) 0.625
LowSloppyPhrase 117.98 (2.5%) 118.53
(3.2%) 0.5% ( -5% - 6%) 0.611
PKLookup 198.36 (2.2%) 199.34
(1.7%) 0.5% ( -3% - 4%) 0.424
MedSloppyPhrase 52.11 (2.3%) 52.37
(2.9%) 0.5% ( -4% - 5%) 0.542
BrowseMonthSSDVFacets 4.65 (14.6%) 4.67
(15.4%) 0.5% ( -25% - 35%) 0.915
HighTermDayOfYearSort 354.00 (1.7%) 356.01
(1.4%) 0.6% ( -2% - 3%) 0.251
MedSpanNear 118.13 (2.8%) 118.85
(3.4%) 0.6% ( -5% - 7%) 0.540
MedTermDayTaxoFacets 17.07 (2.1%) 17.18
(1.7%) 0.6% ( -3% - 4%) 0.297
Respell 40.13 (1.8%) 40.38
(1.8%) 0.6% ( -2% - 4%) 0.266
AndHighMedDayTaxoFacets 29.22 (1.1%) 29.43
(1.2%) 0.7% ( -1% - 3%) 0.051
HighPhrase 54.55 (1.4%) 54.95
(1.5%) 0.7% ( -2% - 3%) 0.107
Prefix3 149.74 (5.4%) 151.03
(3.4%) 0.9% ( -7% - 10%) 0.549
MedPhrase 155.10 (1.2%) 156.71
(1.4%) 1.0% ( -1% - 3%) 0.013
LowSpanNear 168.63 (3.2%) 170.49
(3.9%) 1.1% ( -5% - 8%) 0.324
Fuzzy1 80.40 (3.3%) 81.62
(2.9%) 1.5% ( -4% - 7%) 0.123
Fuzzy2 78.61 (3.9%) 79.84
(3.2%) 1.6% ( -5% - 8%) 0.163
OrNotHighMed 542.60 (4.8%) 551.16
(4.2%) 1.6% ( -7% - 11%) 0.266
IntSet 794.07 (3.9%) 806.99
(3.1%) 1.6% ( -5% - 8%) 0.142
HighTermTitleSort 129.70 (2.8%) 131.85
(2.8%) 1.7% ( -3% - 7%) 0.059
AndHighHigh 345.95 (3.0%) 352.27
(5.9%) 1.8% ( -6% - 10%) 0.214
BrowseDayOfYearSSDVFacets 4.63 (14.3%) 4.71
(16.4%) 1.9% ( -25% - 38%) 0.694
OrHighHigh 407.65 (3.1%) 416.03
(5.8%) 2.1% ( -6% - 11%) 0.161
OrHighNotMed 789.81 (4.1%) 806.23
(6.1%) 2.1% ( -7% - 12%) 0.206
BrowseRandomLabelSSDVFacets 3.09 (4.5%) 3.17
(9.7%) 2.5% ( -11% - 17%) 0.305
BrowseDateSSDVFacets 0.91 (7.8%) 0.93
(5.8%) 2.5% ( -10% - 17%) 0.244
OrHighMed 579.17 (2.2%) 598.98
(4.3%) 3.4% ( -3% - 10%) 0.002
AndHighMed 529.81 (1.6%) 548.32
(3.6%) 3.5% ( -1% - 8%) 0.000
HighTermMonthSort 1362.64 (2.9%) 1420.03
(2.8%) 4.2% ( -1% - 10%) 0.000
Wildcard 788.01 (3.1%) 821.42
(3.4%) 4.2% ( -2% - 11%) 0.000
LowPhrase 572.79 (1.4%) 599.26
(1.3%) 4.6% ( 1% - 7%) 0.000
HighTerm 1037.42 (2.5%) 1085.74
(6.2%) 4.7% ( -3% - 13%) 0.002
MedTerm 1140.70 (3.7%) 1198.80
(5.0%) 5.1% ( -3% - 14%) 0.000
OrHighNotLow 1093.24 (3.5%) 1157.63
(4.9%) 5.9% ( -2% - 14%) 0.000
LowTerm 1595.88 (2.6%) 1714.75
(7.5%) 7.4% ( -2% - 18%) 0.000
OrHighLow 1027.76 (2.5%) 1107.88
(2.1%) 7.8% ( 3% - 12%) 0.000
OrNotHighLow 1456.36 (2.5%) 1575.86
(2.5%) 8.2% ( 3% - 13%) 0.000
AndHighLow 1279.96 (3.2%) 1418.90
(3.5%) 10.9% ( 3% - 18%) 0.000
```
- `AtomicInteger`
```
TaskQPS baseline StdDevQPS my_modified_version StdDev
Pct diff p-value
IntSet 824.23 (5.1%) 812.38
(5.1%) -1.4% ( -11% - 9%) 0.371
Fuzzy2 79.65 (3.1%) 78.82
(3.7%) -1.0% ( -7% - 5%) 0.335
Fuzzy1 71.11 (2.6%) 70.48
(2.9%) -0.9% ( -6% - 4%) 0.312
MedTermDayTaxoFacets 40.99 (1.1%) 40.74
(1.1%) -0.6% ( -2% - 1%) 0.073
TermDTSort 255.15 (3.2%) 253.86
(2.6%) -0.5% ( -6% - 5%) 0.588
Respell 33.25 (1.7%) 33.09
(2.3%) -0.5% ( -4% - 3%) 0.437
AndHighHighDayTaxoFacets 16.63 (1.4%) 16.57
(1.7%) -0.4% ( -3% - 2%) 0.429
IntNRQ 438.66 (1.9%) 437.29
(1.4%) -0.3% ( -3% - 3%) 0.557
LowSloppyPhrase 33.33 (4.3%) 33.32
(4.9%) -0.0% ( -8% - 9%) 0.980
HighTermTitleBDVSort 74.23 (1.5%) 74.24
(1.7%) 0.0% ( -3% - 3%) 0.973
BrowseMonthTaxoFacets 2.77 (1.5%) 2.77
(1.5%) 0.0% ( -2% - 3%) 0.961
BrowseDateSSDVFacets 0.87 (10.0%) 0.87
(9.3%) 0.1% ( -17% - 21%) 0.985
PKLookup 198.31 (1.9%) 198.66
(2.3%) 0.2% ( -3% - 4%) 0.789
HighTermDayOfYearSort 293.62 (1.8%) 294.17
(2.2%) 0.2% ( -3% - 4%) 0.767
BrowseDateTaxoFacets 3.15 (4.8%) 3.15
(4.7%) 0.2% ( -8% - 10%) 0.872
BrowseDayOfYearTaxoFacets 3.17 (4.7%) 3.18
(4.6%) 0.3% ( -8% - 10%) 0.862
OrHighMedDayTaxoFacets 11.82 (2.4%) 11.85
(1.9%) 0.3% ( -3% - 4%) 0.702
HighSloppyPhrase 25.82 (3.4%) 25.91
(4.3%) 0.3% ( -7% - 8%) 0.788
BrowseRandomLabelTaxoFacets 2.38 (1.7%) 2.39
(1.9%) 0.3% ( -3% - 3%) 0.540
BrowseRandomLabelSSDVFacets 3.22 (11.0%) 3.24
(10.4%) 0.7% ( -18% - 24%) 0.842
OrNotHighMed 402.90 (6.4%) 405.86
(6.8%) 0.7% ( -11% - 14%) 0.726
HighSpanNear 41.21 (2.7%) 41.54
(2.6%) 0.8% ( -4% - 6%) 0.345
MedSloppyPhrase 120.35 (2.8%) 121.37
(3.4%) 0.8% ( -5% - 7%) 0.400
AndHighMedDayTaxoFacets 102.67 (0.7%) 103.56
(0.7%) 0.9% ( 0% - 2%) 0.000
BrowseDayOfYearSSDVFacets 4.52 (12.3%) 4.57
(11.9%) 1.2% ( -20% - 28%) 0.754
MedIntervalsOrdered 150.85 (5.1%) 152.78
(4.4%) 1.3% ( -7% - 11%) 0.400
range 2091.05 (5.3%) 2120.20
(5.9%) 1.4% ( -9% - 13%) 0.432
LowSpanNear 159.05 (1.5%) 161.43
(1.8%) 1.5% ( -1% - 4%) 0.004
MedSpanNear 199.13 (1.7%) 202.46
(1.8%) 1.7% ( -1% - 5%) 0.002
HighIntervalsOrdered 37.62 (7.1%) 38.25
(5.7%) 1.7% ( -10% - 15%) 0.408
OrNotHighHigh 310.96 (7.1%) 316.57
(6.1%) 1.8% ( -10% - 16%) 0.389
LowIntervalsOrdered 252.22 (6.2%) 256.93
(5.2%) 1.9% ( -8% - 14%) 0.303
HighPhrase 336.99 (1.8%) 344.07
(1.6%) 2.1% ( -1% - 5%) 0.000
LowPhrase 321.18 (1.2%) 328.13
(1.0%) 2.2% ( 0% - 4%) 0.000
AndHighHigh 269.68 (3.2%) 275.84
(2.0%) 2.3% ( -2% - 7%) 0.007
OrHighNotHigh 398.46 (6.5%) 407.98
(5.2%) 2.4% ( -8% - 14%) 0.196
Wildcard 409.00 (2.5%) 419.40
(4.2%) 2.5% ( -4% - 9%) 0.021
MedPhrase 380.32 (1.4%) 390.52
(1.3%) 2.7% ( 0% - 5%) 0.000
BrowseMonthSSDVFacets 4.65 (15.9%) 4.82
(16.6%) 3.8% ( -24% - 43%) 0.465
OrHighHigh 313.96 (5.9%) 325.76
(3.3%) 3.8% ( -5% - 13%) 0.014
OrHighMed 470.47 (3.3%) 488.29
(2.0%) 3.8% ( -1% - 9%) 0.000
MedTerm 949.35 (4.9%) 986.95
(3.5%) 4.0% ( -4% - 13%) 0.003
AndHighMed 620.70 (1.6%) 647.41
(0.9%) 4.3% ( 1% - 6%) 0.000
HighTermMonthSort 1388.47 (3.1%) 1450.18
(2.6%) 4.4% ( -1% - 10%) 0.000
Prefix3 547.58 (3.8%) 574.60
(5.4%) 4.9% ( -4% - 14%) 0.001
OrNotHighLow 1355.83 (2.9%) 1440.87
(2.8%) 6.3% ( 0% - 12%) 0.000
OrHighLow 999.86 (2.1%) 1065.32
(1.9%) 6.5% ( 2% - 10%) 0.000
OrHighNotMed 1269.64 (3.0%) 1354.01
(4.6%) 6.6% ( 0% - 14%) 0.000
HighTerm 1125.78 (3.6%) 1206.11
(5.1%) 7.1% ( -1% - 16%) 0.000
OrHighNotLow 1078.83 (3.4%) 1162.69
(4.6%) 7.8% ( 0% - 16%) 0.000
LowTerm 1725.12 (2.9%) 1868.98
(2.5%) 8.3% ( 2% - 14%) 0.000
HighTermTitleSort 149.94 (2.8%) 164.35
(2.4%) 9.6% ( 4% - 15%) 0.000
AndHighLow 1505.07 (3.0%) 1677.05
(4.0%) 11.4% ( 4% - 19%) 0.000
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
