gun-pi commented on issue #15605: URL: https://github.com/apache/lucene/issues/15605#issuecomment-3793986415
> Initially I was looking the same but found this comment https://github.com/apache/lucene/pull/240/changes#r710742109. Hmmm, as I understand, Lucene users can collect collectors themselves and implement early termination detection on their own too. That's because they can use `TopFieldCollectorManager` in multithread environment (like in my case). Also, I don't see the getCollectors method being used in the tests. So I can conclude that this method and collector collection logic in the constructor are unnecessary. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
