uschindler commented on PR #15616: URL: https://github.com/apache/lucene/pull/15616#issuecomment-3805195555
Hi, > Separately: are we sure we still need these specific back-compat tests!? On major release, we are supposed to remove any test cases testing now unsupported index formats -- Lucene 8.4 indices are long ago not readable (as of 10.0.0+) -- why do we still have them? Let's not make the read side back compat burden even harder by carrying forward long-obsolete tests!! I also noticed this. We never cleaned up our old indexes. We should remove all backwards codecs and especially their write support for no-longer supported index versions (of course you may need to keep older parts like postings writer). So basically remove everything thats not needed anymre after removing the top-level-codecs for each version. Basically the backwards tests open all indexes back to Lucene 1.x, but they ponly test that the blob produces a meaningful exception. But it should really make sure that the indexes can be opened without any codecs (so the test should say "too old" and not "missing codec"). Uwe -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
