romseygeek commented on PR #15632: URL: https://github.com/apache/lucene/pull/15632#issuecomment-3817944332
NB: I initially tried to extend this to TermOrdValComparator as well, but that causes test failures. This is because the existing tests use randomly-distributed data, so the SkipBlockRangeIterator can't actually filter out any values. This is probably still a better implementation than the existing one, however, because currently we are using a competitive iterator that ends up checking the value of every document in turn. I think we can address this in a follow-up by adjusting the test to use an index sort. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
