benwtrent commented on code in PR #15607:
URL: https://github.com/apache/lucene/pull/15607#discussion_r2743171466
##########
lucene/core/src/java/org/apache/lucene/util/hnsw/HnswGraphBuilder.java:
##########
@@ -67,6 +67,8 @@ public class HnswGraphBuilder implements HnswBuilder {
protected final int M; // max number of connections on upper layers
private final double ml;
+ private final int[] bulkScoreNodes; // for bulk scoring
+ private final float[] bulkScores; // for bulk scoring
Review Comment:
@kaivalnp the scorer itself isn't threadsafe. I assumed that since we were
using a scorer, we were OK.
I had the same threading concerns and looked up and it seems that each
thread as a unique builder object instance (The worker of the thread) and they
all work on the same graph.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]